MinItems with dynamic blocks #22221
Merged
MinItems with dynamic blocks #22221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a block was defined via "dynamic", there will be only one block value until the expansion is known. Since we can't detect dynamic blocks at this point, don't verify MinItems while there are unknown values in the config. The decoder spec can also only check for existence of a block, so limit the check to 0 or 1.
If there are unknowns, the block may have come from a dynamic declaration, and we can't validate MinItems. Once the blocks are expanded, we will get the full config for validation without any unknown values.
jbardin
force-pushed
the
jbardin/min-items
branch
from
2d9ba52 to
4bed030
Compare
mildwonkey
approved these changes
Jul 29, 2019
jhoos
pushed a commit
to jhoos/terraform
that referenced
this pull request
Aug 9, 2019
Having multiple dynamic blocks for the same block, where only one of them will actually resolve to a real block, doesn't pass validation because Terraform sees both blocks and thinks MaxItems is violated. This changes things (similar to how hashicorp#22221 did for MinItems) so that the validation is relaxed until later on when the dynamic blocks are resolved.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MinItems> 1 can't be validated directly from the configuration is using dynamic blocks.We need to skip the validation in a few places to let these through.
Fixes #22195